Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Pagination Previous: Add border and spacing support #66393

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Query Pagination Previous: Add border and spacing support #66393

wants to merge 3 commits into from
+21 −1

Conversation

karthick-murugan
Copy link
Contributor

@karthick-murugan karthick-murugan commented Oct 24, 2024 •
edited
Loading

What?

Add border and spacing block support to the Query Pagination Previous ( Previous Page ) block.

Part of #43247
Part of #43243

Why?

Query Pagination Previous ( Previous Page ) block is missing border and spacing support.

How?

Adds the border and spacing block support in block.json

Testing Instructions

  • Go to Appearance > Editor > Styles > Edit Styles > Blocks.
  • Ensure the Query Pagination Previous (Previous Page) block's border and spacing is configurable via Global Styles.
  • Confirm Global Styles are applied correctly in both the editor and frontend.
  • Edit a template or page and add a Query Loop block.
  • Select a variation (e.g., Title & Date) and adjust pagination to display the "Previous Link."
  • Select the Previous Page block and verify border, radius and spacing settings are available.
  • Check that block styles take precedence over Global Styles.
  • Ensure borders and spacing display correctly in both the editor and frontend.

Testing Instructions for Keyboard

None.

Screenshots or screencast

In Backend:

query_prev_backend

In Front End:

query_prev_frontend

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 24, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthick-murugan! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@karthick-murugan karthick-murugan changed the title Query Pagination Previous Border Support Query Pagination Previous: Add border and spacing support Oct 24, 2024
@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block labels Oct 24, 2024
This was referenced Oct 24, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karthick-murugan @akasunil